RTSP H265 Aggregation packet support #2413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tonihei, could you please help with review and moving forward with the change? |
microkatz
reviewed
May 20, 2025
| int endOfData = data.bytesLeft(); | ||
| int currentPosition = 2; // skipping payload header (2 bytes) | ||
| do { | ||
| int nalUnitSize = ((data.getData()[currentPosition] & 0xFF) << 8) |
There was a problem hiding this comment.
Is this equivalent to data.readUnsignedShort()?
ParsableByteArray operations utilized instead of manual bytes manipulation
|
Hi @microkatz thank you for review and comment, could you please review again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregation packet support for H265 RTSP added according to the specification.
The implementation is based on the assumption that DONL won't be present in the packet since
sprop-max-don-diff != 0is not supportedFixes issue: #1008